prevent prefer-get from warning on computed expressions with variables

wix-incubator · Oct 8, 2015 · 2c2ea5c · 2c2ea5c
1 parent 67f86c1
commit 2c2ea5c
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/lib/util/astUtil.js b/lib/util/astUtil.js
@@ -93,12 +93,19 @@ function isCallFromObject(node, objName) {
     return node && node.type === 'CallExpression' && _.get(node, 'callee.object.name') === objName;
 }
 
+function isComputed(node) {
+    return _.get(node, 'computed') && node.property.type !== 'Literal';
+}
 
 function isEquivalentExp(a, b) {
+
     return _.isEqual(a, b, function(left, right, key) {
         if (_.includes(['loc', 'range', 'computed'], key)) {
             return true;
         }
+        if (isComputed(left) || isComputed(right)) {
+            return false;
+        }
         if (key === 'property') {
             var leftValue = left.name || left.value;
             var rightValue = right.name || right.value;

diff --git a/tests/lib/rules/prefer-get.js b/tests/lib/rules/prefer-get.js
@@ -18,7 +18,8 @@ ruleTester.run('prefer-get', rule, {
         'var x = _.get(a, "b.c");',
         'var x = _.has(a, "b.c");',
         'var x = a && a.b',
-        'a && a.b && f()'
+        'a && a.b && f()',
+        'a && a[v] && a[v].c'
     ],
     invalid: [{
         code: 'x = a && a.b && a.b.c === 8',