fix error in callback-binding in methods without callbacks

wix-incubator · Jan 26, 2016 · c985ba9 · c985ba9
1 parent 599e8e7
commit c985ba9
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/lib/rules/callback-binding.js b/lib/rules/callback-binding.js
@@ -26,7 +26,7 @@ module.exports = function (context) {
         4: function (node, iteratee) {
             var isTransformerMethod = transformerMethods.some(lodashUtil.isCallToMethod.bind(null, node, settings.version));
             var iterateeIndex = node.arguments.indexOf(iteratee);
-            if ((isTransformerMethod && node.arguments[iterateeIndex + 2]) || (!isTransformerMethod && node.arguments[iterateeIndex + 1])) {
+            if (iterateeIndex !== -1 && (isTransformerMethod && node.arguments[iterateeIndex + 2] || (!isTransformerMethod && node.arguments[iterateeIndex + 1]))) {
                 context.report(iteratee, 'Do not use Lodash 3 thisArg, use binding instead');
             }
         }

diff --git a/tests/lib/rules/callback-binding.js b/tests/lib/rules/callback-binding.js
@@ -20,7 +20,8 @@ ruleTester.run('callback-binding', rule, {
         'var r = _.find(arr, function (i) { return this.x; }.bind(this, x));'
     ].map(optionsUtil.fromVersion3).concat([
         'var x = _.map(arr, f.bind(this))',
-        'var x = _.find(users, function(user) { return user.age > this.age}.bind(this));'
+        'var x = _.find(users, function(user) { return user.age > this.age}.bind(this));',
+        'var t = _.isArray(x)'
     ]),
     invalid: [
         'var r = _.find(users, function (user) { return user.age > this.age; }.bind(this));',