Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preferred alias errors on toString #117

Closed
SpainTrain opened this issue Oct 24, 2016 · 1 comment
Closed

preferred alias errors on toString #117

SpainTrain opened this issue Oct 24, 2016 · 1 comment

Comments

@SpainTrain
Copy link
Contributor

Once #115 was closed, we began seeing this failure:

/home/ubuntu/hz-webapp/app/components/buyer/offer/compose-helpers.js
   79:12  error  Method 'toString' is an alias, for consistency prefer using 'function toString() { [native code] }'  lodash/preferred-alias
  106:20  error  Method 'toString' is an alias, for consistency prefer using 'function toString() { [native code] }'  lodash/preferred-alias
  109:17  error  Method 'toString' is an alias, for consistency prefer using 'function toString() { [native code] }'  lodash/preferred-alias

/home/ubuntu/hz-webapp/app/components/common/readonly-field.js
  64:71  error  Method 'toString' is an alias, for consistency prefer using 'function toString() { [native code] }'  lodash/preferred-alias

The native toString method is of course not a lodash alias and arguably this conflicts with prefer-lodash-method.

Here's a minimal repro

import {toString} from 'lodash'

toString('something')
3:1  error  Method 'toString' is an alias, for consistency prefer using 'function toString() { [native code] }'  lodash/preferred-alias

@ganimomer
Copy link
Contributor

Fixed in 2.1.7. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants