Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prefer-compact should warn if filter uses default identity function #177

Closed
martinmacko47 opened this issue Feb 3, 2018 · 2 comments
Closed

prefer-compact should warn if filter uses default identity function #177

martinmacko47 opened this issue Feb 3, 2018 · 2 comments

Comments

@martinmacko47
Copy link

As prefer-compact considers an explicit identity function a warning:

_.filter(arr, (x) => x)

It should consider the implicit one a warning as well, shouldn't it?

_.filter(arr)
@ganimomer
Copy link
Contributor

ganimomer commented Feb 4, 2018 •
edited

You're right, it should. Fixing.

@ganimomer
Copy link
Contributor

Fixed in version 2.6.1. Thanks for opening the issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@martinmacko47 @ganimomer