Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CalendarList - blank space instead of month when scrolling fast #325

Closed
mharrisweb opened this issue Jan 31, 2018 · 11 comments
Closed

CalendarList - blank space instead of month when scrolling fast #325

mharrisweb opened this issue Jan 31, 2018 · 11 comments

Comments

@mharrisweb
Copy link

Description

When scrolling from month to month, using the CalendarList, If you scroll quickly the month is displayed in large bold text, with an empty calendar.

Expected Behavior

If scrolling quickly through CalendarList. Month appears as blank space.

Observed Behavior

No error, just blank space instead of month,.

Environment

  • npm ls react-native-calendars: react-native-calendars@1.16.1
  • npm ls react-native: react-native@0.50.3

Samsung s8 Android V7

Reproducible Demo

videotogif_2018 01 31_15 52 55

@tautvilas
Copy link
Contributor

Hi, this is the result of calendars optimization. Calendar days are not rendered until calendar scrolls into view. If you scroll really fast, rendering lags and for a short time you see placeholder that is visible until calendars are loaded (the other alternative would be to have blank calendars until they are rendered)

@mharrisweb
Copy link
Author

mharrisweb commented Feb 1, 2018

Hi @tautvilas

So it cant be prevented? Could I use onVisibleMonthsChange to just render the current/ next and previous months?

Also, would I be able to put a loading spinner in instead of the placeholder?

@tautvilas
Copy link
Contributor

Currently you can not customize placeholder. This is the place in code that you can change in your fork to display something else:

https://github.com/wix/react-native-calendars/blob/master/src/calendar-list/item.js#L45

@mharrisweb
Copy link
Author

Can I setup a pull request to add that functionaility?

@tautvilas
Copy link
Contributor

Yes

@Mahdi-Farahani
Copy link

i have this issue how can i fix it? @tautvilas

@leonardorib
Copy link

leonardorib commented Oct 23, 2022

I would also like to be able to customize this placeholder.

I just created a pull request: #2067

@pfcodes
Copy link

pfcodes commented Nov 20, 2022

Placeholder much needed

@paula-morales
Copy link

Are you planning to merge the PR soon? 🙏

@MursiDirect
Copy link

Any Solution yet?

@PauloBarroso85
Copy link

Are you planning to merge the PR soon? 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants