Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to react-native 0.31.0 #234

Closed
DanielZlotin opened this issue Aug 24, 2016 · 16 comments
Closed

Upgrade to react-native 0.31.0 #234

DanielZlotin opened this issue Aug 24, 2016 · 16 comments
Assignees

Comments

@DanielZlotin
Copy link
Contributor

No description provided.

@musicode
Copy link

is it complete?

@explorigin
Copy link

No, this is an issue to track the process.

@musicode
Copy link

how long to wait for it?

@DanielZlotin
Copy link
Contributor Author

DanielZlotin commented Aug 28, 2016

iOS is completed (RN31)
Working on Android

@musicode
Copy link

iOS RN32 available?

@DanielZlotin
Copy link
Contributor Author

No, we have a weird bug when using anything higher than 31 on iOS. see https://github.com/wix/react-native-navigation/issues/257

@DanielZlotin
Copy link
Contributor Author

update: RN31 works great on iOS, works OK on Android.

There are indications of memory issues on Android but that's probably related to the temp hack we did with view unmounting/detaching that we need to remove. Easy peasy.

@bbrock25
Copy link

@DanielZlotin will you be releasing a version bump for this in the near future?

@DanielZlotin
Copy link
Contributor Author

@bbrock25 iOS is already out (with the controllers update), Android should be soon. Unfortunately, we are blocked by the fact we use this framework along with lots of other libraries in production, some of which do not support RN>25. we are working hard on migrating.

@DanielZlotin
Copy link
Contributor Author

By soon, I mean we plan doing it next Monday. No guarantees yet.

@musicode
Copy link

By soon, I mean we plan doing it next Monday. No guarantees yet.

how about RN32?

@explorigin
Copy link

Hey guys, I just wanted to say Thanks! This is a much needed package in the RN space. Please pass on my gratitude to your respective employers for offering your time in such a way that we can all benefit from.

@DanielZlotin
Copy link
Contributor Author

@musicode as said in https://github.com/wix/react-native-navigation/issues/257#issuecomment-242979908 - I started seeing weird issues of views not appearing when going from 31 to 32 on iOS. So as I see it now, we will upgrade to RN31 first in order not to jump too high all at once.

@DanielZlotin
Copy link
Contributor Author

updated to RN31 in v2.0.0-experimental.91.
We need to remove some left over hacks, I'll open a separate issue. Please report any resulting difficulties.

@DanielZlotin
Copy link
Contributor Author

DanielZlotin commented Sep 5, 2016

Breaking changes:

Nothing in native (we hide the implementation for you in our NavigationApplication), but when moving your project to RN31, you should know about a few RN breaking changes:

  • importing React, {Component, PropTypes} must be from react and not react-native (used to throw warning, will blow up now)
  • ActivityIndicatorIOS is deprecated, replace with ActivityIndicator (both platforms are supported now)
  • specifying flex: 1 in places that you don't need it will now break your ui completely
  • specifying flexWrap: wrap without alignItems: flex-start will now break your ui

@AdamBrodzinski
Copy link

@DanielZlotin Great to hear! and keep up the great work!! If there's anything I can test specifically let me know, going to try this out tomorrow. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants