-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to react-native 0.31.0 #234
Comments
is it complete? |
No, this is an issue to track the process. |
how long to wait for it? |
iOS is completed (RN31) |
iOS RN32 available? |
No, we have a weird bug when using anything higher than 31 on iOS. see https://github.com/wix/react-native-navigation/issues/257 |
update: RN31 works great on iOS, works OK on Android. There are indications of memory issues on Android but that's probably related to the temp hack we did with view unmounting/detaching that we need to remove. Easy peasy. |
@DanielZlotin will you be releasing a version bump for this in the near future? |
@bbrock25 iOS is already out (with the controllers update), Android should be soon. Unfortunately, we are blocked by the fact we use this framework along with lots of other libraries in production, some of which do not support RN>25. we are working hard on migrating. |
By soon, I mean we plan doing it next Monday. No guarantees yet. |
how about RN32? |
Hey guys, I just wanted to say Thanks! This is a much needed package in the RN space. Please pass on my gratitude to your respective employers for offering your time in such a way that we can all benefit from. |
@musicode as said in https://github.com/wix/react-native-navigation/issues/257#issuecomment-242979908 - I started seeing weird issues of views not appearing when going from 31 to 32 on iOS. So as I see it now, we will upgrade to RN31 first in order not to jump too high all at once. |
updated to RN31 in |
Breaking changes: Nothing in native (we hide the implementation for you in our NavigationApplication), but when moving your project to RN31, you should know about a few RN breaking changes:
|
@DanielZlotin Great to hear! and keep up the great work!! If there's anything I can test specifically let me know, going to try this out tomorrow. 👍 |
No description provided.
The text was updated successfully, but these errors were encountered: