-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is RN v0.57.8 supported on Android? #4623
Comments
Just to give you some feedback, I have RNN working with RN 0.57.8 on Android. PS: What's interesting is that I'm not able to run on iOS (but I'm not sure if it is something related to this package) |
@j0nd0n7 Okay, that means it's more of a personal problem, thanks! |
I can confirm that RN 0.57.8 works with RNN on both iOS and Android. |
@jinshin1013 What version of React Native Navigation are you using and which build flavor in android/app/build.gradle? |
I've got 2 projects running: RNN: 2.7.1 |
@jinshin1013 Thanks for the information. Would you mind sharing your app/build.gradle and the android/build.gradle setup. Cant seem to get this working with my current setup and im unable to see whats wrong. Thanks! |
I was having same issue,
I forgot to add Ignore for RNN flavors, for me I needed to ignore reactNative57_5 since I am using RN: 0.57.2 For you I guess you need to update your dependency on android/app/build.gradle to be
Here is the dependency table Don't forget to ignore the RNN flavors you are not using, android/build.gradle
Above case is for me, if you add names.contains("reactNative57") that will be true and you will have an issue, you need to use something for equality instead of contains. I hope this work for you |
Ha! Thanks @lchapoy you must be right. I had all that except I was blindly following the instructions and was ignoring using |
If you don't want to have to write all different React Native variants, you could just do this. As more variants are created, managing it manually would get very tedious. |
I've made a boilerplate project if you are interested in having a look. It's using:
|
@jinshin1013 yeah the option seems better, except that I recently started working on this project for the first time. I didn't need to talk to the author or anyone else, I just knew it used react native. I looked up react native documentation and learned of the |
@lchapoy unfortunately I still have the issue. I was already ignoring the other versions:
I even tried deleting the |
I agree with you on having "non-standard" command to run the project may cause some confusion especially when working with people without prior knowledge on the project. However, in saying that each developer must ensure that all the required commands and scripts are written in package.json command so they do not even have to look for documentations on the internet to run the project. But yeah at least we got multiple choices to choose from. |
Thanks for the example boilerplate @jinshin1013 . It's helped. What I was missing was in android/build.gradle I was missing |
@jinshin1013 Thanks for the boilerplate. Got it working. Im not sure what I got wrong but after I have updated all of the gradle files to match the boilerplate I still had the error as listed above. But after i deleted node_modules and reinstalled it I got it working. Thanks! |
you saved my day , someone should update documentation to mark this as addition |
Hi @jinshin1013, could you please specify which line should I put? It is from the path android/build.gradle or android/app/build.gradle? The problem I encountered as below image |
Issue Description
Trying to run RNN with RN v0.57.8
iOS is working, but I'm having an issue running on Android.
The compilation fails with a lot of issues, the first one is:
If nobody has gotten this working, what's the highest version currently supported?
Steps to Reproduce / Code Snippets / Screenshots
full error logs if you're interested:
Environment
The text was updated successfully, but these errors were encountered: