Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static backButtonHidden / title on scene? #633

Closed
kyle-ssg opened this issue Jan 3, 2017 · 5 comments
Closed

Static backButtonHidden / title on scene? #633

kyle-ssg opened this issue Jan 3, 2017 · 5 comments

Comments

@kyle-ssg
Copy link
Contributor

kyle-ssg commented Jan 3, 2017

More of a question rather than an issue, I can see you are able to set a number of static properties on a scene component e.g. static navigatorStyle = {}; - is it possible to do the same with title and backbutton enabled ? A lot of my routes have multiple entry points and would like to reuse as much config as possible.

@kyle-ssg kyle-ssg changed the title Static backButtonHidden / title Static backButtonHidden / title on scene Jan 3, 2017
@kyle-ssg kyle-ssg changed the title Static backButtonHidden / title on scene Static backButtonHidden / title on scene? Jan 3, 2017
@DanielZlotin DanielZlotin added this to the 2.0.0 milestone Jan 4, 2017
@DanielZlotin DanielZlotin added v2.0.0 and removed WIP labels Feb 19, 2017
@Kureev
Copy link

Kureev commented Apr 24, 2017

Hey guys,

What's the status of this issue? Do you have any ideas in mind of what needs to be done here?

I also see you removed 2.0 label from this issue, does it mean that it should be removed from the milestone as well?

@DanielZlotin
Copy link
Contributor

The labels were too messy so I removed them but this feature is correctly assigned to 2.x.x milestone

@DanielZlotin
Copy link
Contributor

The idea is to basically support 2 different set of options in 2 different ways. styles and buttons, dynamic and static.
Meaning:
All screen specific styles will be configurable by setting static navigationStyle = {...} in the screen components,
Likewise, all button stuff will be configurable by setting static navigationButtons = {...}, including enabled: false.

The same configuration object (with a future feature to override only certain values) will be settable dynamically by calling setStyle / setButtons with a screen Id.

@stale
Copy link

stale bot commented Nov 26, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If you believe the issue is still relevant, please test on the latest Detox and report back. Thank you for your contributions.

@stale stale bot added the 🏚 stale label Nov 26, 2018
@stale
Copy link

stale bot commented Dec 3, 2018

The issue has been closed for inactivity.

@stale stale bot closed this as completed Dec 3, 2018
React Native Navigation automation moved this from To Do to Done Dec 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

3 participants