Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS 15 UISheetPresentationController Detents #7320

Open
1 task done
zachgibson opened this issue Oct 19, 2021 · 6 comments
Open
1 task done

iOS 15 UISheetPresentationController Detents #7320

zachgibson opened this issue Oct 19, 2021 · 6 comments

Comments

@zachgibson
Copy link

zachgibson commented Oct 19, 2021

🚀 Feature

It would be great to support iOS 15 UISheetPresentationController detents so page sheet modals can have multiple “snap points”.

Motivation

This would allow for greater customization and enhanced user experience when using page sheet modal styles in iOS 15 and greater.

Pitch

One of the main benefits I see of this feature would be a native stack inside a “bottom sheet”. This is currently impossible AFAIK to inject a native RNN stack into a RN based bottom sheet. This would also be a great alternative to React Native or JS based bottom sheets where performance and UX sometimes suffer.

Are you willing to resolve this issue by submitting a Pull Request?

  • ✖️   Yes, I have the time, and I know how to start.
  • ✅   Yes, I have the time, but I don't know how to start. I would need guidance.
  • ✖️   No, I don’t have the time and I’m okay to wait for the community / maintainers to resolve this issue.
@svbutko
Copy link
Collaborator

svbutko commented Oct 19, 2021

I can try to implement it, I have an interest in this feature too, I'll try to do something about it this week.

@zachgibson
Copy link
Author

I'm here too if I can help out in any way.

@zachgibson
Copy link
Author

@svbutko any updates on this?

@svbutko
Copy link
Collaborator

svbutko commented Jan 11, 2022

@zachgibson sorry I don't have enough time at this moment, the PR which is there in drafts has everything implemented, there are just two issues which have nothing to do with the feature itself but with the way how data is passed from RN to native, and if it will be fixed, then everything should work

@oferRounds
Copy link

hi any chance this can be continued?

@oferRounds
Copy link

hey @yogevbd, any plans to finish the support for this iOS feature?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants