Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect stVars type in Stylable exports #2249

Closed
tzachbon opened this issue Jan 6, 2022 · 0 comments · Fixed by #2256
Closed

Incorrect stVars type in Stylable exports #2249

tzachbon opened this issue Jan 6, 2022 · 0 comments · Fixed by #2256
Labels
bug Unexpected behavior or exception core Processing and transforming logic runtime Runtime API types Typing related

Comments

@tzachbon
Copy link
Contributor

tzachbon commented Jan 6, 2022 •
edited
Loading

Actual Behavior

stVars type is currently defined incorrectly as Record<string, string> and in fact, it could be nested with st-map and st-array.

(Both in @stylable/core and @stylable/runtime)

Expected Behavior

Should support arrays and maps.

Version

4.10.0 (latest)

Relevant log output

Example for complex case

Additional Context

No response
@tzachbon tzachbon added bug Unexpected behavior or exception types Typing related labels Jan 6, 2022
@tzachbon tzachbon mentioned this issue Jan 6, 2022
Closed
@tomrav tomrav added core Processing and transforming logic runtime Runtime API labels Jan 6, 2022
@tzachbon tzachbon mentioned this issue Jan 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Unexpected behavior or exception core Processing and transforming logic runtime Runtime API types Typing related
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Stylable variables exports type and generated dts and sourcemaps files wix/stylable
2 participants
@tomrav @tzachbon