Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(experiments): update experiments settings schema in package.json #82

Merged
merged 1 commit into from
Sep 21, 2019
Merged

fix(experiments): update experiments settings schema in package.json #82

merged 1 commit into from
Sep 21, 2019

Conversation

M-Izadmehr
Copy link
Contributor

@M-Izadmehr M-Izadmehr commented Sep 19, 2019 •
edited

The settings schema expects glean.experiments to be string, however, the current value for experiments is an array of strings.
The purpose of this small PR is to fix the settings schema.

It fixes one of the problems mentioned in #75

@M-Izadmehr M-Izadmehr mentioned this pull request Sep 21, 2019
Closed
@borislit borislit merged commit 92066b5 into wix-incubator:master Sep 21, 2019
borislit pushed a commit that referenced this pull request Sep 21, 2019
@semantic-release-bot
chore(release): 4.16.0 [skip ci]
12a3d7b 
# [4.16.0](v4.15.2...v4.16.0) (2019-09-21)

### Bug Fixes

* **experiments:** update experiments settings schema in package.json ([#82](#82)) ([92066b5](92066b5))

### Features

* **class-to-functional:** added ability to disable conversion warning ([a6a0789](a6a0789))
@borislit
Copy link
Contributor

🎉 This PR is included in version 4.16.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@M-Izadmehr @borislit