Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation warning with PHP 8 #318

Closed
ghost opened this issue Dec 11, 2020 · 2 comments
Closed

Deprecation warning with PHP 8 #318

ghost opened this issue Dec 11, 2020 · 2 comments

Comments

@ghost
Copy link

ghost commented Dec 11, 2020

Just upgraded to PHP 8 on my local and seeing this warning on a number of lines in gump.class.php:

Deprecated: Required parameter $value follows optional parameter $params in /Volumes/WIP/local/localhost/vendor/wixel/gump/gump.class.php on line 1159

Deprecated: Required parameter $value follows optional parameter $params in /Volumes/WIP/local/localhost/vendor/wixel/gump/gump.class.php on line 1232

Deprecated: Required parameter $value follows optional parameter $params in /Volumes/WIP/local/localhost/vendor/wixel/gump/gump.class.php on line 1259

Deprecated: Required parameter $value follows optional parameter $params in /Volumes/WIP/local/localhost/vendor/wixel/gump/gump.class.php on line 1276

... etc, etc, etc

Looks like there are a number of methods which have a required parameter following an optional parameter. This practice, of course, nullifies the fact of any optionality of the preceding parameter.

@micabal
Copy link

micabal commented Oct 15, 2021

This should be merged with #324

@filisko
Copy link
Collaborator

filisko commented Jul 14, 2022

Fixed now in #334

Will be released in 2.0.0 with support for php8.

@filisko filisko closed this as completed Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants