Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Helpers class a property of Client #30

Closed
karafra opened this issue Feb 22, 2022 · 1 comment
Closed

Make Helpers class a property of Client #30

karafra opened this issue Feb 22, 2022 · 1 comment
Labels
wontfix This will not be worked on

Comments

@karafra
Copy link

karafra commented Feb 22, 2022

This would open up possibilities for multiclient applications to have independent logging for each client. In my honest opinion this also makes more sense architecture wise, as all properties in Helpers class are bound to client and there is no need for putting them into separate class

@wiz0u
Copy link
Owner

wiz0u commented Feb 22, 2022

I disagree with your analysis. All properties/members of Helper class are absolutely not bound to Client, and perfectly fine as static.
The only problem I recognize is about logging.

Now there are two reasons I will not move Log to Client:

  • I need to be able to log from various methods that are not Client-bound, like Session, Encryption and TL serialization
  • I don't feel the need to particularly help those developers that want to use multiple Clients in their program, as mass-managing fake user profiles goes against Telegram TOS

@wiz0u wiz0u closed this as completed Feb 22, 2022
@wiz0u wiz0u added the wontfix This will not be worked on label May 8, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants