Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong (German) translation on homepage #289

Closed
iophobia opened this issue Nov 2, 2023 · 3 comments
Closed

Fix wrong (German) translation on homepage #289

iophobia opened this issue Nov 2, 2023 · 3 comments
Assignees
Labels
translation Translation issue

Comments

@iophobia
Copy link
Contributor

iophobia commented Nov 2, 2023

I'm aware that Wizarr is localized by Weblate. But as a German user I stumbled over this mishap (see attachment). It seems like the variable for the server name was just turned into a hardcoded "names Server". I've found no way to address that so I thought opening a ticket would make sense.

I'm on v3.4.2 by the way.
wizarr

Edit: Okay, seems it's as easy as exchanging %{name}s Server for %{server_name}s Server in the German app.po on line 1133. I'm not accustomed to PRs, so if anybody feels like it, your help would be appreciated.

@JamsRepos
Copy link
Member

Hey! If you wish to contribute to translations, you can do so on our Weblate and it'd be great if you could proof read them all and correct where need be.
https://hosted.weblate.org/projects/wizarr-v3/wizarr/de/

@JamsRepos
Copy link
Member

I've tested this on my local.

Gib deinen Einladungscode für %{server_name}s Server ein! works, i've submitted the suggestion to remove the s on the end, which should work.

Please note, the server name is grabbed from /admin/settings/media and uses the Display Name.

@Krallenkiller
Copy link

Since I created the German translation, I can confirm that there were errors in version 3.4.2. These were corrected approximately two weeks ago and are no longer present from version 3.4.8 onwards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translation Translation issue
Projects
None yet
Development

No branches or pull requests

4 participants