fix(backend): user sync error on plex managed/guest users #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lookup by token instead of username to handle Plex Managed and Guest users accounts
This was
linked to
issues
Apr 11, 2024
Merged
This was referenced Apr 11, 2024
wizarr-sentry bot
pushed a commit
that referenced
this pull request
Apr 11, 2024
# [4.0.0-beta.1](v3.5.1...v4.0.0-beta.1) (2024-04-11) ### Bug Fixes * 🐛 refactor server_api.py and software_lifecycle.py for better exception handling ([8cf2b32](8cf2b32)) * 🐝 🐛 Remove trailing slashes on server URL's ([c4cfd77](c4cfd77)) * 🩹 🐛 Fixed copy server URL when override set ([ab5e680](ab5e680)) * 🩹 🔥 Removed remaining label ([268fda9](268fda9)) * **backend:** user sync error on plex managed/guest users ([#357](#357)) ([1467046](1467046)) * **frontend:** 🐛 users without token no longer cause error on scan ([#344](#344)) ([05ce4f5](05ce4f5)) * **frontend:** cant remove discord widget id ([#347](#347)) ([fefcb06](fefcb06)) * remove latest info widget ([#353](#353)) ([37e21fe](37e21fe)) * **wizarr-backend:** 🚑 added password strength test ([ff83c30](ff83c30)) ### chore * 🧽 fix versioning file ([66cef97](66cef97)) ### Features * finshed backend password change ([5b1ce2e](5b1ce2e)) * password reset frontend done, backend started ([d15e0a1](d15e0a1)) * **wizarr-frontend:** 🚀 Add extended labels to buttons ([72c7dc4](72c7dc4)) ### Performance Improvements * 🚀 ✨ Changed to use floating vue ([ce0b92f](ce0b92f)) ### BREAKING CHANGES * begin 4.x.x versioning
wizarr-sentry bot
pushed a commit
that referenced
this pull request
Apr 29, 2024
## [3.6.0](v3.5.1...v3.6.0) (2024-04-29) ### ⚠ BREAKING CHANGES * begin 4.x.x versioning ### New Features * ✨ ✨ Emby users can now set max streams ([3b0d4e0](3b0d4e0)) * 🎉 ✨ Added Emby Support ([c882992](c882992)) * 🎉 ✨ Scanning in Emby users now attaches connect email as user email ([46d6f22](46d6f22)) * 🎉 Live TV can now be enabled/disabled for Jellyfin/Emby invites ([8723d1c](8723d1c)) * 🎊 ✨ Emby and Jellyfin now update username/email on an updated scan ([7c158ca](7c158ca)) * 🚑 added ability to specify concurrent sessions on jellyfin ([#378](#378)) ([062bc6b](062bc6b)), closes [#377](#377) * finshed backend password change ([5b1ce2e](5b1ce2e)) * password reset frontend done, backend started ([d15e0a1](d15e0a1)) * **wizarr-frontend:** 🚀 Add extended labels to buttons ([72c7dc4](72c7dc4)) ### Bug Fixes * 🐛 🐛 Fixed issue where Emby/Plex would error on creating an invite ([eb54d32](eb54d32)) * 🐛 📝 Fix the form being the wrong namr ([602d5d1](602d5d1)) * 🐛 refactor server_api.py and software_lifecycle.py for better exception handling ([8cf2b32](8cf2b32)) * 🐝 🐛 Remove trailing slashes on server URL's ([c4cfd77](c4cfd77)) * 🐝 Corrected Live TV for Jellyfin ([1b94a6e](1b94a6e)) * 🐝 update toast can now be dismissed ([f2585ca](f2585ca)) * 🩹 🎨 Resolved scaling of theme selector on help wizard ([ccf75fc](ccf75fc)) * 🩹 🐛 Fixed copy server URL when override set ([ab5e680](ab5e680)) * 🩹 🐛 Fixed issue where Jellyseerr could not be selected for Emby servers ([83c381a](83c381a)) * 🩹 🔥 Removed remaining label ([268fda9](268fda9)) * 🩹 change delete user call to emby function ([139cf86](139cf86)) * 🩹 Default Live TV checkbox to enabled to reflect Jellyfin/Emby default ([1cba8c3](1cba8c3)) * 🩹 Fixed error which occured when using LDAP ([1ba2e0a](1ba2e0a)) * **backend:** user sync error on plex managed/guest users ([#357](#357)) ([1467046](1467046)) * **discord-release-alert:** 🐛 mentions failing in embeded payload ([8e87c41](8e87c41)) * **frontend:** 🐛 users without token no longer cause error on scan ([#344](#344)) ([05ce4f5](05ce4f5)) * **frontend:** cant remove discord widget id ([#347](#347)) ([fefcb06](fefcb06)) * remove latest info widget ([#353](#353)) ([37e21fe](37e21fe)) * **wizarr-backend:** 🚑 added password strength test ([ff83c30](ff83c30)) ### Performance Improvements * 🚀 ✨ Changed to use floating vue ([ce0b92f](ce0b92f)) * **test:** changelog ([7eacd08](7eacd08)) ### Build System * **deps:** 🔨 🏗️ update browserslist to latest ([b9b95bc](b9b95bc)) * **npm:** add conventionalcommit changelog package ([633868a](633868a)) * **semantic-release:** 👷 add explict typing for changelog ([62ef792](62ef792)) * **semantic-release:** 👷 update discord webhook payload to [@dev-updates](https://github.com/dev-updates) ([d0886bf](d0886bf)) * **semantic-release:** 🧱 add other commit types to changelog ([6b49b2a](6b49b2a)) * **semantic-release:** use conventioncommits preset ([582982f](582982f)) * **test:** changelog ([54955f5](54955f5)) ### Continuous Integration * 🔧 auto merge release branch back into beta ([43b4c9d](43b4c9d)) * 🔧 fix missing apostrophe causing action fail ([429b4f6](429b4f6)) * 🔧 update action naming to better align with workflow ([a7ab17a](a7ab17a)) * 🧪 fix nightly action name ([291cb18](291cb18)) * 🧪 nightly image builds off develop branch ([05d5331](05d5331)) * **test:** changelog ([24e565f](24e565f)) ### Chores * 🧹 bump db migration script version/date ([a71ada5](a71ada5)) * 🧺 ✏️ Fixed a type with the setup finalisation ([00d6143](00d6143)) * 🧽 add unRaid support ([71c00e1](71c00e1)) * 🧽 fix versioning file ([66cef97](66cef97)) * 🧽 remove changelog test file ([3191b0a](3191b0a)) * 🧽 update visibility of hidden beta items ([f44ea0b](f44ea0b)) * clean up unused refrences ([7b97be4](7b97be4)) * **gitignore:** add nvm versioning file ([daa8e6c](daa8e6c)) * **release:** 3.5.1-beta.7 ([3a26ead](3a26ead)) * **release:** 4.0.0-beta.1 ([3a90b8d](3a90b8d)), closes [#357](#357) [#344](#344) [#347](#347) [#353](#353) * **release:** 4.0.0-beta.2 ([d6bd390](d6bd390)) * **release:** 4.0.0-beta.3 ([709e009](709e009)) * **release:** 4.0.0-beta.4 ([6e9ba8d](6e9ba8d)) * **release:** 4.0.0-beta.5 ([a74aafd](a74aafd)) * **release:** 4.0.0-beta.6 ([9dc466a](9dc466a)) * **release:** 4.0.0-beta.7 ([cd74551](cd74551)) * **release:** 4.0.0-beta.8 ([0f5d8e0](0f5d8e0)), closes [#377](#377) * **release:** 4.0.0-beta.9 ([724755e](724755e)) * start of v4 development 🎆🎆 ([80e95dc](80e95dc)) * **translations:** 🧺 extract strings ([a96a18f](a96a18f)) * **workspace:** 🧹 add commit editor extension and config ([423c59c](423c59c)) * **workspace:** 🧺 add nx console extension ([7bc90d1](7bc90d1)) ### Documentation * 📖 📝 Corrected grammatical issues with Download page on Jellyfin ([0ba2a78](0ba2a78)) * 📚 📝 Fixed Emby showing in the Jellyfin download page ([4302699](4302699)) * 📚 refactor portions of contribution guide ([07ae431](07ae431)) * 📚 update build badge for new action names ([a218de1](a218de1)) * 📝 create contribution guide in project root dir ([619a97b](619a97b)) * added warning against modifying the $server_name variable ([e27f375](e27f375)) * readme/setup/unraid refactor ([#364](#364)) ([afc180d](afc180d)) * **readme:** 📚 update discord release channel ([7d8afc9](7d8afc9)) * **readme:** fix build badge ([97116ee](97116ee)) * refactor contribution guide ([642b3cd](642b3cd)) * **test:** changelog ([a09f31c](a09f31c)) * **test:** changelog ([4a479e5](4a479e5)) ### Style Changes * 🎨 new wizarr logo/branding ([#361](#361)) ([864a3df](864a3df)) * 💎 minor corrections to discord alert payload ([c03c2cf](c03c2cf)) * 💎 simplify image tag condition ([8930479](8930479)) * add specifc image tag targeting beta/latest ([71da180](71da180)) * another correction for the backticks ([428fec7](428fec7)) * backticks corrected ([eb4259a](eb4259a)) * **discord-webhook:** 🎨 role mentions for new channel structure ([2c30e4c](2c30e4c)) * fix apostrophe usage ([3be097c](3be097c)) * fix backticks reaking payload formatting ([0ebf1c7](0ebf1c7)) * removed an extra space ([c96e72e](c96e72e)) * simplify image tag statement check ([96a18ae](96a18ae)) * **test:** changelog ([463db02](463db02)) * update discord webhook message ([d8310a7](d8310a7)) * Updated logo with mustache ([#363](#363)) ([86827b3](86827b3)) ### Code Refactoring * 📦 💄 Added password meter to new password field ([e35680a](e35680a)) * 📦 ⚡ Remove membership and live chat ([3b08550](3b08550)) * 📦 added tooltip to scan server in media server settings ([2fdfab2](2fdfab2)) * 📦 hiding unimplemented features ([5c7082f](5c7082f)) * 🔧 📝 Added warning about open collective ([ae29be3](ae29be3)) * 🔧 add e2e workspace, exclude apps dir ([12054f7](12054f7)) * 🔧 moved password to account page ([dfc6490](dfc6490)) * 🔧 spelling and grammatical corrections ([9eb591f](9eb591f)) * 🔨 added tooltip to request access button ([3d576a4](3d576a4)) * **test:** changelog ([7e2aacd](7e2aacd)) * **test:** changelog ([9370752](9370752)) * update nginx values on docs ([d7e52a9](d7e52a9)) * **workspace:** 🔧 update dev workspace and sorting ([9c2561a](9c2561a))
wizarr-sentry bot
pushed a commit
that referenced
this pull request
Apr 29, 2024
## [4.0.0](v3.5.1...v4.0.0) (2024-04-29) ### ⚠ BREAKING CHANGES * begin 4.x.x versioning ### New Features * ✨ ✨ Emby users can now set max streams ([3b0d4e0](3b0d4e0)) * 🎉 ✨ Added Emby Support ([c882992](c882992)) * 🎉 ✨ Scanning in Emby users now attaches connect email as user email ([46d6f22](46d6f22)) * 🎉 Live TV can now be enabled/disabled for Jellyfin/Emby invites ([8723d1c](8723d1c)) * 🎊 ✨ Emby and Jellyfin now update username/email on an updated scan ([7c158ca](7c158ca)) * 🚑 added ability to specify concurrent sessions on jellyfin ([#378](#378)) ([062bc6b](062bc6b)), closes [#377](#377) * finshed backend password change ([5b1ce2e](5b1ce2e)) * password reset frontend done, backend started ([d15e0a1](d15e0a1)) * **wizarr-frontend:** 🚀 Add extended labels to buttons ([72c7dc4](72c7dc4)) ### Bug Fixes * 🐛 🐛 Fixed issue where Emby/Plex would error on creating an invite ([eb54d32](eb54d32)) * 🐛 📝 Fix the form being the wrong namr ([602d5d1](602d5d1)) * 🐛 refactor server_api.py and software_lifecycle.py for better exception handling ([8cf2b32](8cf2b32)) * 🐝 🐛 Remove trailing slashes on server URL's ([c4cfd77](c4cfd77)) * 🐝 Corrected Live TV for Jellyfin ([1b94a6e](1b94a6e)) * 🐝 update toast can now be dismissed ([f2585ca](f2585ca)) * 🩹 🎨 Resolved scaling of theme selector on help wizard ([ccf75fc](ccf75fc)) * 🩹 🐛 Fixed copy server URL when override set ([ab5e680](ab5e680)) * 🩹 🐛 Fixed issue where Jellyseerr could not be selected for Emby servers ([83c381a](83c381a)) * 🩹 🔥 Removed remaining label ([268fda9](268fda9)) * 🩹 change delete user call to emby function ([139cf86](139cf86)) * 🩹 Default Live TV checkbox to enabled to reflect Jellyfin/Emby default ([1cba8c3](1cba8c3)) * 🩹 Fixed error which occured when using LDAP ([1ba2e0a](1ba2e0a)) * **backend:** user sync error on plex managed/guest users ([#357](#357)) ([1467046](1467046)) * **discord-release-alert:** 🐛 mentions failing in embeded payload ([8e87c41](8e87c41)) * **frontend:** 🐛 users without token no longer cause error on scan ([#344](#344)) ([05ce4f5](05ce4f5)) * **frontend:** cant remove discord widget id ([#347](#347)) ([fefcb06](fefcb06)) * remove latest info widget ([#353](#353)) ([37e21fe](37e21fe)) * **wizarr-backend:** 🚑 added password strength test ([ff83c30](ff83c30)) ### Performance Improvements * 🚀 ✨ Changed to use floating vue ([ce0b92f](ce0b92f)) * **test:** changelog ([7eacd08](7eacd08)) ### Build System * **deps:** 🔨 🏗️ update browserslist to latest ([b9b95bc](b9b95bc)) * **npm:** add conventionalcommit changelog package ([633868a](633868a)) * **semantic-release:** 👷 add explict typing for changelog ([62ef792](62ef792)) * **semantic-release:** 👷 update discord webhook payload to [@dev-updates](https://github.com/dev-updates) ([d0886bf](d0886bf)) * **semantic-release:** 🧱 add other commit types to changelog ([6b49b2a](6b49b2a)) * **semantic-release:** use conventioncommits preset ([582982f](582982f)) * **test:** changelog ([54955f5](54955f5)) ### Continuous Integration * 🔧 auto merge release branch back into beta ([43b4c9d](43b4c9d)) * 🔧 fix missing apostrophe causing action fail ([429b4f6](429b4f6)) * 🔧 update action naming to better align with workflow ([a7ab17a](a7ab17a)) * 🧪 fix nightly action name ([291cb18](291cb18)) * 🧪 nightly image builds off develop branch ([05d5331](05d5331)) * **semantic-release:** 🔧 explicity define breaking changes ([b144ff2](b144ff2)) * **test:** changelog ([24e565f](24e565f)) ### Chores * 🧹 bump db migration script version/date ([a71ada5](a71ada5)) * 🧺 ✏️ Fixed a type with the setup finalisation ([00d6143](00d6143)) * 🧽 add unRaid support ([71c00e1](71c00e1)) * 🧽 fix versioning file ([66cef97](66cef97)) * 🧽 remove changelog test file ([3191b0a](3191b0a)) * 🧽 update visibility of hidden beta items ([f44ea0b](f44ea0b)) * clean up unused refrences ([7b97be4](7b97be4)) * **gitignore:** add nvm versioning file ([daa8e6c](daa8e6c)) * **release:** 3.5.1-beta.7 ([3a26ead](3a26ead)) * **release:** 4.0.0-beta.1 ([3a90b8d](3a90b8d)), closes [#357](#357) [#344](#344) [#347](#347) [#353](#353) * **release:** 4.0.0-beta.2 ([d6bd390](d6bd390)) * **release:** 4.0.0-beta.3 ([709e009](709e009)) * **release:** 4.0.0-beta.4 ([6e9ba8d](6e9ba8d)) * **release:** 4.0.0-beta.5 ([a74aafd](a74aafd)) * **release:** 4.0.0-beta.6 ([9dc466a](9dc466a)) * **release:** 4.0.0-beta.7 ([cd74551](cd74551)) * **release:** 4.0.0-beta.8 ([0f5d8e0](0f5d8e0)), closes [#377](#377) * **release:** 4.0.0-beta.9 ([724755e](724755e)) * start of v4 development 🎆🎆 ([80e95dc](80e95dc)) * **translations:** 🧺 extract strings ([a96a18f](a96a18f)) * **workspace:** 🧹 add commit editor extension and config ([423c59c](423c59c)) * **workspace:** 🧺 add nx console extension ([7bc90d1](7bc90d1)) ### Documentation * 📖 📝 Corrected grammatical issues with Download page on Jellyfin ([0ba2a78](0ba2a78)) * 📚 📝 Fixed Emby showing in the Jellyfin download page ([4302699](4302699)) * 📚 refactor portions of contribution guide ([07ae431](07ae431)) * 📚 update build badge for new action names ([a218de1](a218de1)) * 📝 create contribution guide in project root dir ([619a97b](619a97b)) * added warning against modifying the $server_name variable ([e27f375](e27f375)) * readme/setup/unraid refactor ([#364](#364)) ([afc180d](afc180d)) * **readme:** 📚 update discord release channel ([7d8afc9](7d8afc9)) * **readme:** fix build badge ([97116ee](97116ee)) * refactor contribution guide ([642b3cd](642b3cd)) * **test:** changelog ([a09f31c](a09f31c)) * **test:** changelog ([4a479e5](4a479e5)) ### Style Changes * 🎨 new wizarr logo/branding ([#361](#361)) ([864a3df](864a3df)) * 💎 minor corrections to discord alert payload ([c03c2cf](c03c2cf)) * 💎 simplify image tag condition ([8930479](8930479)) * add specifc image tag targeting beta/latest ([71da180](71da180)) * another correction for the backticks ([428fec7](428fec7)) * backticks corrected ([eb4259a](eb4259a)) * **discord-webhook:** 🎨 role mentions for new channel structure ([2c30e4c](2c30e4c)) * fix apostrophe usage ([3be097c](3be097c)) * fix backticks reaking payload formatting ([0ebf1c7](0ebf1c7)) * removed an extra space ([c96e72e](c96e72e)) * simplify image tag statement check ([96a18ae](96a18ae)) * **test:** changelog ([463db02](463db02)) * update discord webhook message ([d8310a7](d8310a7)) * Updated logo with mustache ([#363](#363)) ([86827b3](86827b3)) ### Code Refactoring * 📦 💄 Added password meter to new password field ([e35680a](e35680a)) * 📦 ⚡ Remove membership and live chat ([3b08550](3b08550)) * 📦 added tooltip to scan server in media server settings ([2fdfab2](2fdfab2)) * 📦 hiding unimplemented features ([5c7082f](5c7082f)) * 🔧 📝 Added warning about open collective ([ae29be3](ae29be3)) * 🔧 add e2e workspace, exclude apps dir ([12054f7](12054f7)) * 🔧 moved password to account page ([dfc6490](dfc6490)) * 🔧 spelling and grammatical corrections ([9eb591f](9eb591f)) * 🔨 added tooltip to request access button ([3d576a4](3d576a4)) * **test:** changelog ([7e2aacd](7e2aacd)) * **test:** changelog ([9370752](9370752)) * update nginx values on docs ([d7e52a9](d7e52a9)) * **workspace:** 🔧 update dev workspace and sorting ([9c2561a](9c2561a))
|
🎉 This PR is included in version 4.0.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors the create_user function to lookup user by token rather than username. This fixes the sync error related to Plex Managed/Guest users, allowing them to be properly added to the database.
Fixes #322 and #352