App will show a list of movies and a detail screen #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
App request several lists of movies by topic App display each requested list on a collection view App play backgroud music App display a detail screen for when user select a movie.
JDandini
approved these changes
Nov 17, 2021
|
Amigo por fa mergea tus cambios |
Refactor Decoder GroupDispatch for requests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
App request several lists of movies by topic
App display each requested list on a collection view
App play backgroud music
App display a detail screen for when user select a movie.
Where should the reviewer start?
Files:
MoviesViewController
Movie
APIManager
Preview
Code review checklist Code Review Rubric
DRY Principle (Don’t repeat yourself)
Yagni Principle (You Aren't Gonna Need It)
KISS Principle (Keep It Simple, St...d)
Remove unused code
Hard-coded values
Language style guide & coding conventions
Wizeline Style Guide
RayWenderlich Style Guide
Architecture / Design Pattern
Architecture Implementation
SOLID
Single Responsibility Principle
Open Closed Principle
Liskov substitutability principle
Interface segregation
Dependency Inversion principle
Testing
Force unwrapping !
Mutable vs immutable property (Right use of
letandvar)Retain cycles (Capture list)
Code Documentation