-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle Streams #1
Comments
The pull request has updated tests, and should properly handle streams now. Would this be ok to merge in? Do you want to discuss further? |
Wonderful work, you almost rewrite the whole code base, I'll look into it ASAP. BTW: I just observed one unit test failed in your PR. |
Please let me know. All unit tests passed on my side. I have also upgraded the packages, so make sure to do an npm install before npm test. |
Finally, I changed |
code merged, so close this issue. |
The current plugin doesn't handle streams. Ideally Gulp plugins should handle the three types of vinyl:
https://github.com/gulpjs/gulp/blob/master/docs/writing-a-plugin/README.md
The text was updated successfully, but these errors were encountered: