Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Streams #1

Closed
tjchaplin opened this issue Jun 5, 2016 · 5 comments
Closed

Handle Streams #1

tjchaplin opened this issue Jun 5, 2016 · 5 comments
Assignees

Comments

@tjchaplin
Copy link
Contributor

The current plugin doesn't handle streams. Ideally Gulp plugins should handle the three types of vinyl:

  • Streams
  • Buffers
  • Empty (null) - Useful for things like rimraf, clean, where contents is not needed.

https://github.com/gulpjs/gulp/blob/master/docs/writing-a-plugin/README.md

@tjchaplin
Copy link
Contributor Author

The pull request has updated tests, and should properly handle streams now.

Would this be ok to merge in? Do you want to discuss further?

@wizicer wizicer self-assigned this Jun 6, 2016
@wizicer
Copy link
Owner

wizicer commented Jun 6, 2016

Wonderful work, you almost rewrite the whole code base, I'll look into it ASAP.

BTW: I just observed one unit test failed in your PR.

@tjchaplin
Copy link
Contributor Author

Please let me know. All unit tests passed on my side. I have also upgraded the packages, so make sure to do an npm install before npm test.

@wizicer
Copy link
Owner

wizicer commented Jun 6, 2016

Finally, I changed replace(/\s\n/g,'') to replace(/\s?\n/g,'') to make it work, my test bed is linux which only generate \n.

@wizicer wizicer closed this as completed Jun 8, 2016
@wizicer
Copy link
Owner

wizicer commented Jun 8, 2016

code merged, so close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants