Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disqus embed color scheme breaks on toggle #15

Closed
wjh18 opened this issue Nov 28, 2022 · 1 comment
Closed

Disqus embed color scheme breaks on toggle #15

wjh18 opened this issue Nov 28, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@wjh18
Copy link
Owner

wjh18 commented Nov 28, 2022

Describe the bug
Disqus auto-detects a site's color scheme and displays the embed with the appropriate contrast. When the color scheme is manually toggled via the theme's light/dark mode switcher, the Disqus embed is not toggled with it to the opposite color scheme and is difficult to read.

To Reproduce
Steps to reproduce the behavior:

  1. Load a post with Disqus comments. The embed should look good.
  2. Toggle the color scheme to the opposite one without reloading the page.
  3. The embed should now have multiple elements with insufficient contrast.
  4. Reload the page and the color scheme that was just not working should show sufficient contrast.

Expected behavior
The body of the iframe embed has a class light or dark which controls the color scheme. Target this element with JS and toggle the class when the dark/light mode switch is toggled by a user.

@wjh18 wjh18 added the bug Something isn't working label Nov 28, 2022
@wjh18
Copy link
Owner Author

wjh18 commented Mar 20, 2023

Fixed in above merge

@wjh18 wjh18 closed this as completed Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant