Skip to content
This repository has been archived by the owner on Jan 2, 2023. It is now read-only.

Non-ascii links getting destroyed #5257

Open
PRR24 opened this issue Sep 23, 2022 · 1 comment · May be fixed by #5273
Open

Non-ascii links getting destroyed #5257

PRR24 opened this issue Sep 23, 2022 · 1 comment · May be fixed by #5273

Comments

@PRR24
Copy link

PRR24 commented Sep 23, 2022

wkhtmltopdf version(s) affected: 0.12.5, 0.12.6

OS information
Linux, Windows (probably all)

Description
if links contain (properly) encoded non-ascii characters, these get destroyed by htmltopdf.

How to reproduce

<!DOCTYPE html>
<html lang="en">
<head>
    <meta charset="UTF-8">
</head>
<body>
    <a href="http://localhost/ASDF%C3%B5.pdf">Problem</a>
</body>
</html>

Expected behavior
PDF will have a link to http://localhost/ASDF%C3%B5.pdf

Actial result
PDF has a link to http://localhost/ASDF%25C3%25B5.pdf

Probable cause
Unneccessary/extra encodeURI (or similar) call in link re-encoding.
@PRR24
Copy link
Author

PRR24 commented Sep 25, 2022

Possibly related to #4406

@daveallie daveallie linked a pull request Nov 15, 2022 that will close this issue
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Parse link hrefs assuming they are percent encoded daveallie/wkhtmltopdf
1 participant
@PRR24