Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use nanonext::.unresolved() #49

Closed
wlandau opened this issue Mar 17, 2023 · 4 comments
Closed

Use nanonext::.unresolved() #49

wlandau opened this issue Mar 17, 2023 · 4 comments
Assignees

Comments

@wlandau
Copy link
Owner

wlandau commented Mar 17, 2023

From shikokuchuo/mirai#37, it will be much faster for crew than mirai::unresolved() when the task data is large.

@wlandau wlandau self-assigned this Mar 17, 2023
@wlandau
Copy link
Owner Author

wlandau commented Mar 17, 2023

This means I can remove the n argument from collect() with no loss of efficiency!

@wlandau
Copy link
Owner Author

wlandau commented Mar 17, 2023

Thinking about how to manage this back-compatibly. Maybe I want to grab the function only if it exists in nanonext:

if (exists(x = ".unresolved", envir = getNamespace(name = "nanonext"))) {
  mirai_unresolved <- eval(expr = parse(text = "nanonext::.unresolved"))
} else {
  mirai_unresolved <- nanonext::unresolved
}

The eval(parse()) is to hide from the R CMD check static code analyzer.

@wlandau
Copy link
Owner Author

wlandau commented Mar 17, 2023

Then when the next nanonext is released, I can revert this workaround and require that version of nanonext.

@wlandau
Copy link
Owner Author

wlandau commented Mar 29, 2023

5c046c9 moves entirely to .unresolved() and requires the recently released version 0.8.1 of nanonext.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant