Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve process to pass box shadow color. #18

Closed
Shinyzenith opened this issue Aug 23, 2023 · 2 comments
Closed

Improve process to pass box shadow color. #18

Shinyzenith opened this issue Aug 23, 2023 · 2 comments

Comments

@Shinyzenith
Copy link
Member

Shinyzenith commented Aug 23, 2023

The fact that box_shadow color a float * instead of just a float [4] is problematic.
Wrapping that in FFI is clunky because essentially in zig I need to wrap it as: *f32[4] which might as well just be f32[4].
Not to mention other languages where that kind of pointer arithmetic is usually not suggested. Eg: Python

Why can't we approach it as just float [4]?

@Shinyzenith Shinyzenith changed the title Improve process to pass blur color. Improve process to pass box shadowcolor. Aug 23, 2023
@Shinyzenith Shinyzenith changed the title Improve process to pass box shadowcolor. Improve process to pass box shadow color. Aug 23, 2023
@ErikReider
Copy link
Member

We could use the wlr_render_color struct instead :)

@ErikReider
Copy link
Member

Lol, apparently I fixed this back in January xD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants