Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peer Dependency #1

Closed
weihsth opened this issue Dec 14, 2017 · 3 comments
Closed

Peer Dependency #1

weihsth opened this issue Dec 14, 2017 · 3 comments

Comments

@weihsth
Copy link

weihsth commented Dec 14, 2017

Hi!

I have the problem, that I use protractor AND protractor-helper as dependencies. npm 3+ is not installing protractor, because it's peer dependency from protractor-helper.

Only working solutions:

  • installing protractor globally or particular (no way for me)
  • copy your index file after each module update and paste it to my own module (works but it's just a 'hack')

Can it be removed as peer dependency? Everbody knows that it's needed.

@wlsf82
Copy link
Owner

wlsf82 commented Dec 14, 2017

Hi @weihsth, which version of Protractor do you have in the project where you're facing the issue?
I dislike the idea of removing the peer dependency since this is the only way to ensure a warning will be shown in case Protractor is not installed.
I also noticed you mentioned npm v3+. Have you considered using a newer version?

@weihsth
Copy link
Author

weihsth commented Dec 21, 2017

Hi @wlsf82, I use the protractor 5.1.1 at the moment.
Jea you are correct. It's good to have it. I don't know what the problem was. Since today it works...
Thank you for the reply!

@wlsf82
Copy link
Owner

wlsf82 commented Dec 21, 2017

Good to know that it is working. Let me know if you face it again.

@wlsf82 wlsf82 closed this as completed Dec 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants