-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No putp()/tigetflag()/tigetnum()/... (term.h) makes it messy to build Python wheels #55
Comments
In retrospect, I think it was a terrible mistake to ever include them. I'm not inclined to bring them back. Linking _cursesmodule.c against PDCurses didn't actually work anyway, did it? I mean, in terms of the result being usable. That's why there are multiple alternative Python curses interfaces to work with PDCurses, is it not? I think the correct approach would be to make Python's curses API more portable. Relying on non-working stubs is not the way. (And, it's mostly not possible to make them work -- PDCurses just isn't designed that way at all.) |
Works fine after making some minor modifications and #defining a few macros. The README in the windows-curses repository has an overview of how We've been using it to make a menuconfig interface available on Windows in addition to Linux. The only special-casing in the code is related to resizing (see |
Random idea: Do you think they could be hidden behind a PDCurses compile-time setting? That way, you'd have to explicitly ask for them, and you wouldn't get code compliling but silently failing because it expects the stubs to work otherwise. Can see if you don't want to litter the code up like that though. |
Try to compile (and link) a copy of |
@cgohlke |
These were removed in commit 6b56929 ("Eliminated term.h, terminfo.c; moved mvcur() to move.c").
_cursesmodule.c from Python unconditionally calls them (though the
term.h
#include itself is optional (HAVE_TERM_H
)).Just recording an actual issue caused by the
term.h
removal.Do you think the stubs could be brought back, even if
term.h
is left out?The text was updated successfully, but these errors were encountered: