Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken assertion in ParameterAssertionException #2

Merged
merged 1 commit into from
Apr 29, 2015
Merged

Conversation

thiemowmde
Copy link
Collaborator

This patch:

  • Fix actual bug in ParameterAssertionException.
  • Switch execution order in parameterElementType for performance reasons.
  • Simplify odd $argname variable name. It's called $parameterName in the exceptions. In methods that already have parameter in the name $name should be enough.
  • Add a comment to the strtolower call.
  • Fix newlines at the beginning and end of all files.

@brightbyte
Copy link
Collaborator

Travis build fails on hhvm only due to an incompatibility between the latest versions of hhvm and PHPUnit.

brightbyte pushed a commit that referenced this pull request Apr 29, 2015
Fix broken assertion in ParameterAssertionException (plus various improvements to parameter names and documentation)
@brightbyte brightbyte merged commit 2da5592 into master Apr 29, 2015
@brightbyte brightbyte deleted the fixes branch April 29, 2015 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 participants