Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing break to globeCoordinate.Formatter #99

Merged
merged 1 commit into from Apr 11, 2016
Merged

Conversation

thiemowmde
Copy link
Contributor

  • The main issue here is the missing break.
  • 1 / 36000000 is not an option you can select in the UI, but is something that can be detected by the backend. At the moment this is shown as "special (±2.7777777777778e-8°)". With this addition this is shown as "special (1/10000')"
  • The epsilon must be lowered together with the smallest predefined precision. I'm using the maximum number of zeros that a coordinate value of 360.000000000000… can have before IEEE makes it start becoming fuzzy (this is around 15 significant digits). Try ( 360.1 ).toFixed( 20 ) in the JavaScript console to see what I mean.

@thiemowmde thiemowmde added the bug label Apr 11, 2016
@JonasKress JonasKress merged commit 40897f4 into master Apr 11, 2016
@JonasKress JonasKress deleted the missingBreak branch April 11, 2016 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

2 participants