Merge pull request #832 from wmde/TemplateTestCampaignTest

Fixed risky test in TemplateTestCampaignTest
wmde · Feb 15, 2017 · 4081da6 · 4081da6
2 parents 76d31e4 + 6ea0093
commit 4081da6
Showing 1 changed file with 9 additions and 9 deletions.
diff --git a/tests/Unit/Presentation/TemplateTestCampaignTest.php b/tests/Unit/Presentation/TemplateTestCampaignTest.php
@@ -73,7 +73,15 @@ public function testHasEnded() {
 		$this->assertFalse( $notFinishedCampaign->hasEnded() );
 	}
 
-	public function testIsRunningDataProvider() {
+	/**
+	 * @dataProvider isRunningDataProvider
+	 */
+	public function testIsRunning( bool $expected, array $data ) {
+		$campaign = $this->newCampaign( $data );
+		$this->assertSame( $expected, $campaign->isRunning() );
+	}
+
+	public function isRunningDataProvider() {
 		return [
 			[
 				true,
@@ -110,12 +118,4 @@ public function testIsRunningDataProvider() {
 		];
 	}
 
-	/**
-	 * @dataProvider testIsRunningDataProvider
-	 */
-	public function testIsRunning( bool $expected, array $data ) {
-		$campaign = $this->newCampaign( $data );
-		$this->assertSame( $expected, $campaign->isRunning() );
-	}
-
 }