Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T180124 Print layout #1047

Merged
merged 2 commits into from Nov 28, 2017
Merged

T180124 Print layout #1047

merged 2 commits into from Nov 28, 2017

Conversation

wiese
Copy link
Contributor

@wiese wiese commented Nov 28, 2017

  • print layout w/o footer
  • lose print.css file
  • add html class "client-nojs"/"client-js" to apply script dependend styling
  • add a bootstrap-inspired class "hidden-no-js" which hides marked elements on
    clients with JS disabled
  • add print link to donation confirmation

Depends on wmde/fundraising-frontend-content#54 - not tracked in composer to avoid conflicts

@wiese wiese added the cat17 label Nov 28, 2017
@wiese wiese changed the title T180124 Cat17 print T180124 Print layout Nov 28, 2017
…rint

This adds a html class "client-nojs"/"client-js" to apply script dependend styling
without FOUC - shameless copy from WP.
Also adds a bootstrap-inspired class "hidden-no-js" which hides marked elements on
clients with JS disabled.
@wiese
Copy link
Contributor Author

wiese commented Nov 28, 2017

Updated implementation. /cc @gbirke

@gbirke
Copy link
Member

gbirke commented Nov 28, 2017

After looking at https://phabricator.wikimedia.org/T180956, I saw that direct debit should get a different link text, "Diese Bestätigung (inklusive SEPA-Mandat) ausdrucken".

@gbirke
Copy link
Member

gbirke commented Nov 28, 2017

Will merge this, https://phabricator.wikimedia.org/T180956 is its own, unrelated story.

@gbirke gbirke merged commit 431454b into master Nov 28, 2017
@gbirke gbirke deleted the cat17_print branch November 28, 2017 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 participants