T181273 Make text boxes react faster #1063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add wrapper function for text components that calls the change and validation handler function on keypress events.
|
This solves a problem that was discovered during investigating https://phabricator.wikimedia.org/T181277, but the description there hints more at a problem with overlapping, unclickable elements, probably caused by https://phabricator.wikimedia.org/T181273 |
wiese
reviewed
Dec 1, 2017
| @@ -200,6 +201,16 @@ module.exports = { | |||
| bankDataElements.accountNumberElement.on( 'change', createDefaultChangeHandler( store, 'accountNumber' ) ); | |||
| bankDataElements.bankCodeElement.on( 'change', createDefaultChangeHandler( store, 'bankCode' ) ); | |||
| return component; | |||
| }, | |||
|
|
|||
| makeTextComponentMoreSnappy: function( textComponent, debounceDelay ) { | |||
There was a problem hiding this comment.
I get the point, but maybe createEagerlyValidatingTextComponent would be a better fit.
|
|
||
| t.ok( component.validator.calledOnce, 'validator was called once' ); | ||
| t.ok( component.validator.calledWith( fakeEvent ), 'validator was called with event' ); | ||
| }, 5 ); |
There was a problem hiding this comment.
This plays with the hope that 1 < 5 and thus the debunce will always be finished before we test?!
Wouldn't it be nicer to stub out the _.debounce (it's not SUT) and perform a synchronous test?
For testing the integration with lodash (if that was the goal) we could grab a hold of the timer functions.
wiese
approved these changes
Dec 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add wrapper function for text components that calls the change and
validation handler function on keypress events.