Add preset amount 300 to donation page in 10h16 skin #1208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 6, 2018 10:46
Feature: T191607 Elements from the donation page of 10h16 were moved around after 300 was added in order to make the template better looking
Feature: T191607 Elements from the donation page of 10h16 were moved around after 300 was added in order to make the template better looking
…d into add-300-to-10h16
aniansson
approved these changes
Apr 9, 2018
gbirke
requested changes
Apr 9, 2018
There was a problem hiding this comment.
Looks good, except for the <hr>tags. They show up with different heights in my browsers, even when the web inspectors say they have the same height. Probably has something to do with fractional heights (1pt gives me 1.33 Pixel). Setting the hr height to 2 Pixel will fix this.
added 2 commits
April 9, 2018 16:39
…d into add-300-to-10h16
…d into add-300-to-10h16
|
I don't like those merge commits, did you force-push? |
gbirke
approved these changes
Apr 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature: T191607
Elements from the donation page of 10h16 were moved around after 300 was added
in order to make the template better looking