Update invalid state css rules of donation page input box #1213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzhelyazkova
force-pushed
the
update-invalid-state-form-css
branch
from
e53c904
to
2b417d2
Compare
gbirke
approved these changes
Apr 19, 2018
| @@ -19,6 +19,7 @@ $brand-primary-membership-dark: #4E9242; | |||
| $brand-footer: #cfdbe2; | |||
| $gray-light: #ddd; | |||
| $brand-error: #812923; | |||
| $brand-error-light: #e6d4d3; | |||
| $brand-error-rgba: rgba(129, 41, 35, 0.2); | |||
There was a problem hiding this comment.
I think we should take the opportunity and rename $brand-error-rgba to something more meaningful like $brand-error-dark.
Feature: T182290 The donation amount input box should keep the style of invalid state fields on the donation page.
tzhelyazkova
force-pushed
the
update-invalid-state-form-css
branch
from
2b417d2
to
b4c1f9b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature: T182290
The donation amount input box should keep the style of invalid state fields on the donation page.
p.s. Some indentation (mixing spaces and tabs) was fixed along the way.