Add configuration files for campaigns #1258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
gbirke
force-pushed
the
campaign-config
branch
2 times, most recently
from
fb065b1
to
d607834
Compare
gbirke
changed the title
gbirke
changed the title
gbirke
force-pushed
the
campaign-config
branch
2 times, most recently
from
49396d4
to
1b62c09
Compare
timEulitz
reviewed
Jun 13, 2018
src/Factories/FunFunFactory.php
Outdated
| }; | ||
|
|
||
| $container['campaign_config'] = function (): array { | ||
| // TODO move to CampaignFactory? |
There was a problem hiding this comment.
I don't feel like I understand the purpose / scope of this factory well enough to comment on this, maybe elaborate on this, possibly also in person.
|
Setting aside the On a very minor note, I think we agreed to phase out |
timEulitz
approved these changes
Jun 13, 2018
tzhelyazkova
approved these changes
Jun 14, 2018
Add YAML files that show how we will define A/B testing campaigns in the future. Add a configuration class that can validate the tree structure of the configuration and explains the meaning of each node. TBD: - Add validator class that validates not only completeness and well-formedness but also date format and default_group value - Create command line validator and add it to CI
Add Campaign value object that holds information about running campaigns. Add CampaignBuilder class to create Campaign objects from an array configuration (that comes out of campaigns.yaml)
Use the Doorkeeper feature toggle library to convert each group of each campaign into a feature. The default group of each campaign is always enabled unconditionally. The other groups are converted into conditional features based on date range of the campaign and a percentage.
Replace DonationConfirmationPageSelector with a method in the ChoiceFactory, the central factory where all feature-toggle related choices are made. Fix conation confirmation template in test skin.
Removed DonationConfirmationPageSelector and TemplateTestCampaign. DonationConfirmationPageSelector was superseded by ChoiceFactory::getConfirmationPageTemplate. TemplateTestCampaign was superseded by CampaignConfiguration.
Use an interface for different implementations of the feature toggle library. Add a DoorKeeper implementation. Add a fixture implementation for testing. This allows you to test specific code paths without having to add camapign configrurations configuration, which is kind of environment-dependent.
Move the conditionals and branching out of FunFunFactory. We're not catching any of the Exceptions that the loader might throw, because we want to catch bad configuration in CI.
Change config schema for campaigns to allow for multiple files (for testing, dev settings, etc.) Fix issue where default Twig templates were not available on confirmation page A/B test templates. Add a cache to CampaignConfigurationLoader::loadCampaignConfiguration to avoid having to parse and validate the configuration on every request. Add cache to general caching and cache purging infrastructure.
Now the test code also reads the campaign configuration, being an erly warning method. Moved all campaign and feature-toggle related code in the FunFunFactory to its shared object code instead of (mis)using Pimple for that.
gbirke
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an example on how to configure feature toggles and use them. The previous "campaign" feature for selecting the Confirmation page is replaced by the new A/B testing feature.
This is for https://phabricator.wikimedia.org/T196337