A/B test form design #1410
Merged
A/B test form design #1410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate two different CSS files on build, one for each campaign Make loaded CSS file dynamic
gbirke
force-pushed
the
test-from-design
branch
from
f282eb4
to
b166252
Compare
gbirke
added a commit
to wmde/fundraising-frontend-content
that referenced
this pull request
Dec 19, 2018
Move link, identifier and label to data structure, use the data structure in the template. Make menu items translatable. This is a preparation for being able to generate different menus as part of an A/B test.
gbirke
force-pushed
the
test-from-design
branch
from
2be2adc
to
1b77d63
Compare
Move menu to ChoiceFactory Add route name to the donation/new route. This route name follows the pattern of the URL schema, described in ADR-005. We since we'd risk breaking all banners, the URL stays the same for now.
Turn off form scrolling for group "B".
tzhelyazkova
approved these changes
Dec 20, 2018
KaiNissen
pushed a commit
to wmde/fundraising-frontend-content
that referenced
this pull request
Dec 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://phabricator.wikimedia.org/T212203