Validate payment type #632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbirke
force-pushed
the
default-payment-type
branch
from
ab133e2
to
e17c7eb
Compare
| @@ -331,8 +332,7 @@ $( function () { | |||
|
|
|||
| function paymentDataIsValid() { | |||
| var currentState = store.getState(); | |||
| return currentState.validity.amount || | |||
| ( currentState.donationFormContent.amount && currentState.donationFormContent.paymentType ) ; | |||
| return currentState.validity.amount; | |||
There was a problem hiding this comment.
This might be misleading. It actually is the validity of payment data (including the payment type).
gbirke
force-pushed
the
default-payment-type
branch
from
72715ab
to
46e20d0
Compare
When validating the amount, also check the payment type.
Handle the new distiction between amount and payment type validation on the client side and display error messages accordingly. Renamed all instances of "amount validation" with "payment data validation", including the route. Changed the URL in the template in the CMS wiki.
gbirke
force-pushed
the
default-payment-type
branch
from
46e20d0
to
21dda51
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When validating the amount, also check the payment type.
Fixes phab:T142967