Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved Context folders out of src/ into contexts/ #646

Merged
merged 3 commits into from Sep 5, 2016

Conversation

JeroenDeDauw
Copy link
Contributor

No description provided.

@JeroenDeDauw
Copy link
Contributor Author

JeroenDeDauw commented Sep 2, 2016

So far I've only moved the tests that I already moved once before. Those belonging to contexts but not organized as such still need moving (with or without this PR). Furthermore, this PR makes the namespaces of the newly moved tests mismatch with the directories. I'm leaving both of these things out for now, so we can do them after committing to this approach (by merging this PR), ie: last chance to rage about this :)

@JeroenDeDauw JeroenDeDauw changed the title Moved Context folders out of src/ into contexts/ with own PSR-4 Moved Context folders out of src/ into contexts/ Sep 2, 2016
@gbirke
Copy link
Member

gbirke commented Sep 2, 2016

I'm not sure I understand what this is all about. You're trying to create Bounded Contexts, right? From my understanding, this is necessary when the domain becomes very big and domain objects with the same name get different meanings. I'm not sure if our domain is big enough to justify that but I'm willing to go along.

Ideally, bounded contexts would not share domain objects, maybe share some interfaces, right?
If that's true, then we need to look at the PaymentContext whose domain objects are used by the paypal notification and create donation use cases in the DonatingContext.

@gbirke
Copy link
Member

gbirke commented Sep 2, 2016

Apart from my general lack of understanding: I like the new contexts folder and the organization. +2 for that.

@JeroenDeDauw
Copy link
Contributor Author

What this change does is reorganize the files as we talked about before I went to SoCraTes, see the "Test directory structure" email. The organization into contexts is in the current code and is not changed by this PR.

From my understanding, this is necessary when the domain becomes very big and domain objects with the same name get different meanings. I'm not sure if our domain is big enough to justify that but I'm willing to go along.

Let's talk about that outside of this PR

@gbirke gbirke merged commit e408b03 into master Sep 5, 2016
@gbirke gbirke deleted the MOVE-ALL-THE-THINGS-again branch September 5, 2016 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants