Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move out application specific storage #116

Open
JeroenDeDauw opened this issue Nov 17, 2016 · 2 comments
Open

Move out application specific storage #116

JeroenDeDauw opened this issue Nov 17, 2016 · 2 comments

Comments

@JeroenDeDauw
Copy link
Contributor

JeroenDeDauw commented Nov 17, 2016 •
edited
Loading

A step towards #115

Database tables only used by one application don't need to be in this shared component. (The same goes for fields, though that is definitely more hairy to refactor.)

Can be moved to the management app:

  • BackendBanner.php
  • BackendImpression.php
  • User.php
  • ActionLog.php
@manicki
Copy link
Member

manicki commented Nov 17, 2016

+1

ActionLog.php?

AFAIR this one is "operations-center" specific too, so should be also moved out.

Address.php?

this in turn seems as "shared" as Donation etc are

@JeroenDeDauw
Copy link
Contributor Author

Yeah, checked Address now with my IDE, and it's part of Subscription, directly bound to in the Fun app even outside its data access layer #grump

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JeroenDeDauw @manicki