Factor inputextender and content out of time and globecoordinate experts #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The messages are new and will be translated again. The old messages will be deleted. No problem. |
|
@tobijat @thiemowmde ping |
The `messageGetter` was called with a params array as second parameter. That behavior matched the documentation, but the function usually passed as `messageGetter` (`mw.msg`) expects the params to be given as individual arguments.
|
|
||
| $.extend( ExpertExtender.CalendarHint.prototype, { | ||
| /** | ||
| * @type {util.MessageProvider} |
|
Generally looks sane to me, though I really am not up to speed enough with the JS for that to be very meaningful |
This introduces ExpertExtender with some modules. It makes it possible to reuse the inputextender in other experts, like quantity or monolingualtext.
|
This looks good from an architecture point of view. I can't say much about the details of the code. |
tobijat
added a commit
that referenced
this pull request
Jun 4, 2014
Factor inputextender and content out of time and globecoordinate experts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces ExpertExtender with some modules. It makes it possible to reuse
the inputextender in other experts, like quantity or monolingualtext.
@siebrand, can you please have a look at the renaming of messages?