Add resource dependencies for jquery.ui.suggester #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jquery.ui.core and jquery.ui.position are needed for the suggester to work on non-entity namespaces in the search box. Bug: 66257
|
this also appears to fix https://bugzilla.wikimedia.org/show_bug.cgi?id=66268 (jquery ui styles overriding entity suggester styles) |
mariushoch
added a commit
that referenced
this pull request
Jun 7, 2014
Add resource dependencies for jquery.ui.suggester
|
I guess the code in this component was never tested without loading the entirety of Wikibase? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jquery.ui.core and jquery.ui.position are needed for
the suggester to work on non-entity namespaces in
the search box.
Bug: 66257