Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the selectors to work with monobook #10

Merged
merged 2 commits into from Aug 31, 2014
Merged

Fix the selectors to work with monobook #10

merged 2 commits into from Aug 31, 2014

Conversation

Benestar
Copy link
Contributor

No description provided.

thiemowmde
thiemowmde reviewed Aug 29, 2014
View reviewed changes
resources/skins/default/wikimedia-badges.css
@@ -7,12 +7,12 @@
* @author Bene* < benestar.wikimedia@gmail.com >
*/

.badge-goodarticle {
.portlet .badge-goodarticle {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I know the .portlet class is MonoBook specific and will not work in Vector.

@thiemowmde
Copy link
Contributor

Why not keep the default for all the skins that share the same style anyway?

@Benestar
Copy link
Contributor Author

Apperently no skins can share any style so we have no default. It would also be a false assumption that the "default" is to use a list-style-image.

@thiemowmde
Copy link
Contributor

no skins can share any style so we have no default.

Search for skinStyles in the code base. You can either have a default styles section plus a few skinStyles. And it's even possible to have a default section inside of skinStyles.

It would also be a false assumption that the "default" is to use a list-style-image.

Ok, that's true.

@Benestar
Copy link
Contributor Author

no skins can share any style so we have no default.

Search for skinStyles in the code base. You can either have a default styles section plus a few skinStyles. And it's even possible to have a default section inside of skinStyles.

Sorry, I meant in this case the skins don't share any style.

thiemowmde added a commit that referenced this pull request Aug 31, 2014
@thiemowmde
Merge pull request #10 from wmde/monobook
c88406d 
Fix the selectors to work with monobook
@thiemowmde thiemowmde merged commit c88406d into master Aug 31, 2014
@thiemowmde thiemowmde deleted the monobook branch August 31, 2014 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@Benestar @thiemowmde