New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

when cropping rotated area, it crops different area #10

Closed

ddulhddul opened this issue Jun 12, 2023 · 0 comments

Contributor

ddulhddul commented Jun 12, 2023 •

edited

Loading

Thanks for gif cropperjs lib it helps me a lot in my project,
but I found an issue about rotated area crop.

after cropper.rotate(-45),
cropped blob area is not matched with canvas

I think this is cause of setupCanvas function's rotated box check

    var rotatedBoxWidth = (this.width*Math.cos(radian)+this.height*Math.sin(radian)) * limitRatio;
    var rotatedBoxHeight = (this.height*Math.cos(radian)+this.width*Math.sin(radian)) * limitRatio;

var rotatedBoxWidth = (this.widthMath.cos(radian)+this.heightMath.sin(radian)) * limitRatio;

The text was updated successfully, but these errors were encountered:

ddulhddul mentioned this issue

update setupCanvas to have no minus value of rotatedBox Width, height (cos & sin) #11

Merged

wmlgl closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment