-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate plugin #15
Comments
Could you please explain? I didn't found any related information about 'native' plugin. |
@DenisIzmaylov I've been using the latest version of Dokku and it exists for me.
|
I can confirm that this plugin was causing my deploy issues. Removing it (rm -rf /var/lib/dokku/pluginsdomains-plugin/) fixed me up. |
Thanks for the heads up guys. I will add a deprecation notice to the readme. To UninstallRemove the following files:
Something like this should work, but I have NOT tested... $ rm /etc/nginx/conf.d/dokku-domains.conf
$ find /home/dokku -wholename '*/nginx-domains.conf' -delete Additionally, it looks like that upon upgrading the new built-in Please comment in this thread how well this works for you or how your mileage varies. Thanks, |
@wmluke Note, this and other plugins were the inspiration for the official version. There are some things we feel make dokku a great tool out of the box, and domain handling is one of them. Thanks for all your hard work! |
Hey @josegonzalez, Thanks for the shoutout. In all honesty, I suspected that my simple plugin wasn't keeping up with the needs of users, so I was very pleased to see a Cheers, |
v0.3.10 of Dokku added a native domain management plugin. I've found that this plugin actually breaks deployment of apps on newer versions of Dokku. Would be good if you could add a warning about this in the README.
Thanks for making this awesome plugin, though. It served me well until domains became a standard feature of Dokku 😸
The text was updated successfully, but these errors were encountered: