Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Length in UEIPAddressPoolIdentity #59

Closed
vulcanfan opened this issue Sep 9, 2020 · 1 comment · Fixed by #60
Closed

Length in UEIPAddressPoolIdentity #59

vulcanfan opened this issue Sep 9, 2020 · 1 comment · Fixed by #60

Comments

@vulcanfan
Copy link

Hi,

In ie/ue-ip-address-pool-identity.go shouldn't line 68 be:

return string(v[1:(idlen+1)]), nil

instead of

return string(v[1:idlen]), nil

The last character of the name is dropped otherwise?

Thanks
@wmnsk wmnsk mentioned this issue Sep 10, 2020
Merged
@wmnsk wmnsk closed this as completed in #60 Sep 10, 2020
@wmnsk
Copy link
Owner

wmnsk commented Sep 10, 2020

Thank you for reporting. I've fixed it, and added test for that in #60.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix IE helper methods that return values in string wmnsk/go-pfcp
2 participants
@wmnsk @vulcanfan