Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize template notes questions #118

Closed
amilan17 opened this issue Sep 22, 2021 · 14 comments
Closed

Normalize template notes questions #118

amilan17 opened this issue Sep 22, 2021 · 14 comments

Comments

@amilan17
Copy link
Member

amilan17 commented Sep 22, 2021

See questions in comments below.

@amilan17

This comment has been minimized.

@amilan17 amilan17 added this to the FT-2022-1 milestone Sep 22, 2021
@amilan17 amilan17 added this to Submitted in GRIB2 Amendments via automation Sep 22, 2021
@amilan17

This comment has been minimized.

@amilan17

This comment has been minimized.

@amilan17

This comment has been minimized.

@amilan17

This comment has been minimized.

@amilan17

This comment has been minimized.

@amilan17

This comment has been minimized.

@amilan17 amilan17 changed the title Normalize template notes Normalize template notes questions Sep 22, 2021
@amilan17 amilan17 self-assigned this Sep 22, 2021
@amilan17 amilan17 added this to In progress in Repository Maintenance Sep 22, 2021
@amilan17 amilan17 moved this from Submitted to In progress in GRIB2 Amendments Sep 22, 2021
@sebvi
Copy link
Contributor

sebvi commented Oct 5, 2021

@amilan17 I haven't found the time to look at this but I could have a look before the meetings in November

@amilan17 amilan17 moved this from In progress to In Validation in GRIB2 Amendments Oct 5, 2021
@amilan17
Copy link
Member Author

amilan17 commented Dec 8, 2021

@sebvi will you have time to look at this soon?

@sebvi
Copy link
Contributor

sebvi commented Dec 8, 2021

I will try to have a look at it this evening

@sebvi
Copy link
Contributor

sebvi commented Dec 8, 2021

For the comment that are all similar but differing by only the octet numbers mentioned, I would suggest to add in the templates a reference in the description of the relevant octets and use that reference that instead of the octets in the notes.

I will look at the other cases but it is not easy because I need to find out to which templates they correspond and look at those templates.

@amilan17
Copy link
Member Author

amilan17 commented Dec 9, 2021

For the comment that are all similar but differing by only the octet numbers mentioned, I would suggest to add in the templates a reference in the description of the relevant octets and use that reference that instead of the octets in the notes

Assuming this is related to question D -- it sounds too complicated at the moment to re-design.

@amilan17
Copy link
Member Author

amilan17 commented Dec 9, 2021

@sebvi -- I hope I provided enough context for the questions in this issue. Questions D, F and G are about specific octets...

@amilan17
Copy link
Member Author

new issues created to address specific issues related to notes.

GRIB2 Amendments automation moved this from In Validation to Done Dec 20, 2021
@amilan17 amilan17 removed this from the FT-2022-1 milestone Dec 20, 2021
@amilan17 amilan17 removed this from Done in GRIB2 Amendments Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

2 participants