Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gtk_wayland_get_logical_geom leaks memory? #128

Closed
LBCrion opened this issue Jul 20, 2022 · 3 comments · Fixed by #129
Closed

gtk_wayland_get_logical_geom leaks memory? #128

LBCrion opened this issue Jul 20, 2022 · 3 comments · Fixed by #129

Comments

@LBCrion
Copy link

LBCrion commented Jul 20, 2022

valgrind is showing a memory leak when popup windows are open on a gtk-layer-shell linked application. Digging down, it looking like gtk_wayland_get_logical_geom in src/gtk_wayland.c needs to call g_list_free(list) before returning.

Documentation for gdk_window_get_children says: "The returned list must be freed, but the elements in the list need not be."

@wmww
Copy link
Owner

wmww commented Jul 20, 2022

Yep, that would be a memory leak all right

@wmww wmww mentioned this issue Jul 20, 2022
@wmww wmww closed this as completed in #129 Jul 20, 2022
@wmww
Copy link
Owner

wmww commented Jul 20, 2022

Since it's only leaking a tiny amount of memory per-popup, I don't think this is such a priority that it needs a release right away.

@LBCrion
Copy link
Author

LBCrion commented Jul 21, 2022

Thank you! And indeed, I don't think this is severe enough to warrant an immediate release. Glad to see it fixed though. It was a splinter in my mind for months: I kept looking for a leak in my menu generating code. Should have run valgrind on it long ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants