-
-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python 3.10.0-rc2 not behaving as expected on Github Actions #477
Comments
I was trying something similar with DiddiLeija/text_formatter#43. The Python 3.10 tests are working fine on my case. I was using python-version: ["3.10.0-alpha - 3.10"] And then I tried python-version: ["3.10.0-rc.2"] On a "wontfix" pull request, I implemented a I think there's a missing thing inside the |
It's more to do with how we use it. We call nox and pass the In the case of |
Well, since you've separated the run: nox --non-interactive --session tests-3.10 -- --full-trace This could be a workaround, until there's a final release for Python 3.10. |
If you like this idea, tell me and I will post a PR to apply the changes. |
Yeah this would work. I've done this on my fork but unfortunately I think it could be more complex than that as we're now getting coverage failures (see here) so just trying to figure out why code might be uncovered on 3.10 but not on any other version. It looks like it could be an upstream thing: nedbat/coveragepy#1106 |
Closing in favour of #478 |
Describe the bug
I happened to notice that the Github Actions 3.10.0-rc2 runs were always successful even when others failed, which prompted me to take a look and I discovered that they are successful because nox is simply skipping citing interpreter not found (see below).
I introduced this in #475 because I did the same on some personal projects and saw CI "passing" so thought nothing of it! 🤦🏻
I'll assign this to myself because I'll be sorting it out for my own projects anyway so I'll upstream the solution I find 👍🏻
How to reproduce
Any 3.10.0-rc2 run on Github Actions should do this.
Expected behavior
Should have run nox with python3.10.
Edit: This seems to be because 3.10.0-rc.2 isn't encoded as such on the GHA runner:
So nox is doing exactly what it should be doing here and ignoring a missing interpreter. Should be a simple fix to the GHA file 🙂
The text was updated successfully, but these errors were encountered: