Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unmark command #72

Merged
merged 7 commits into from Nov 19, 2020
Merged

Add unmark command #72

merged 7 commits into from Nov 19, 2020

Conversation

woefe
Copy link
Owner

@woefe woefe commented Nov 16, 2020 •
edited

Adds unmark command and more listing options. Fixes #69

  • Add unmark command
  • Add --order-by option to list command
  • Change behavior of --watched flag and add --unwatched flag
  • Add unmark behavior to ytccf.sh
  • Add database migrations

@woefe
Change watch status to date from simple bool
c2194a2
@woefe
Add --order-by option to list commands
25459ab
@woefe
Add --unwatched flag to list commands
772df01 
The --watched flag has changed its meaning. It now means: only watched
videos are listed. To list all watched and unwatched videos both
--unwatched and --watched flags have to be used.
@woefe
Add unmark command
9e03553
@woefe woefe changed the title Unmark Unmark command Nov 16, 2020
@woefe woefe changed the title Unmark command Add unmark command Nov 16, 2020
@woefe woefe mentioned this pull request Nov 17, 2020
Closed
@wavexx
Copy link

wavexx commented Nov 18, 2020

Everything seems to work as expected after a brief test both via cli and ytccf (alt-u).
Upgrade worked without issue as well.

@Glandos
Copy link
Contributor

Glandos commented Nov 18, 2020

Same for me, migration was OK.

Do you plan to add unwatch to TUI also? Or you better support fzf?

@Glandos
Copy link
Contributor

Glandos commented Nov 18, 2020

After more testing, I found that I'm unable to play a video using ytccf.sh. I always have: ERROR: Cannot connect to the database or query failed unexpectedly. ytcc tui seems to work fine.

@wavexx
Copy link

wavexx commented Nov 18, 2020

ytccf works fine here (first thing I tried)

@woefe
Copy link
Owner Author

woefe commented Nov 19, 2020

Thanks for testing it!

@woefe
Copy link
Owner Author

woefe commented Nov 19, 2020

@Glandos the ytccf script in your setup is probably using the old command. And I don't plan to add unmark support in the tui. I was actually thinking about removing the tui with the 2.0.0 release. The only reason it's still there is Windows support, because I did not yet write a powershell script.

@woefe woefe merged commit 7a1abf8 into master Nov 19, 2020
@woefe woefe deleted the unmark branch February 13, 2021 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mark as not watched
3 participants
@woefe @wavexx @Glandos