Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameter update does not utilize the result from linesearch( ) #1

Closed
zhongwen opened this issue Jul 18, 2016 · 1 comment
Closed

Comments

@zhongwen
Copy link
Contributor

Hi Wojciech,

In https://github.com/wojzaremba/trpo/blob/master/main.py#L168-L170

                theta = linesearch(loss, thprev, fullstep, neggdotstepdir / lm)
                theta = thprev + fullstep
                self.sff(theta)

the theta obtained from linesearch does not affect the result, is there something wrong here? Thanks.

@wojzaremba
Copy link
Owner

Good point. Would you like to fix it, and make sure that it works after ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants