Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide the messageData in the onComplete function #135

Closed
howlowck opened this issue Feb 8, 2019 · 1 comment
Closed

provide the messageData in the onComplete function #135

howlowck opened this issue Feb 8, 2019 · 1 comment
Labels
status:accepted Feature request accepted and work is planned type:discussion Feature discussion in progress

Comments

@howlowck
Copy link
Collaborator

howlowck commented Feb 8, 2019

Is your feature request related to a problem? Please describe.
There is not a way to get the messageData easily in the onComplete function.

Describe the solution you'd like
We should have a way to pass the current messageData to the user in the onComplete function

Describe alternatives you've considered
the only way is to create the abilities function with the context in its outer scope. This might have memory implications when node is running thousands of conversations. (each one would have a separate abilities object in memory)

Additional context
See echoBot in the wolf-botbuilder repo for example.

@kevinleung23 kevinleung23 added type:discussion Feature discussion in progress status:accepted Feature request accepted and work is planned labels Feb 8, 2019
@howlowck
Copy link
Collaborator Author

howlowck commented May 1, 2019

This feature is in the codebase already. The function is in the getStateFuncs object

@howlowck howlowck closed this as completed May 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:accepted Feature request accepted and work is planned type:discussion Feature discussion in progress
Projects
None yet
Development

No branches or pull requests

2 participants