Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function names #112

Closed
miniBill opened this issue Jul 15, 2024 · 1 comment · Fixed by #116
Closed

Function names #112

miniBill opened this issue Jul 15, 2024 · 1 comment · Fixed by #116

Comments

@miniBill
Copy link
Collaborator

We currently have:
name - Cmd
nameTask - Task
nameBackendTask - BackendTask
nameEffect - Command (lamdera/program-test)

And all the risky variants. If we add avh/elm-program-test this is probably going to become unwieldy.

Proposal: multiple modules.
If there is a single package just use Cmd/Task in Module.Api
If there are multiple packages just use Cmd/Task in Module.Api.Package

So, current users are unaffected, and users with multiple types will get things like:

Github.Api.ElmHttp.getStarsTask
Github.Api.Avh4ElmProgramTest.getStarsTask

Instead of having to invent a new suffix for each package and type combination.

@wolfadex
Copy link
Owner

This is definitely worth it I think. Especially that it doesn't change anything for basic users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants