Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for custom actions (#112) #112

Merged
merged 55 commits into from
Feb 16, 2023
Merged

feat: add support for custom actions (#112) #112

merged 55 commits into from
Feb 16, 2023

Conversation

wolfenrain
Copy link
Owner

@wolfenrain wolfenrain commented Nov 3, 2022 •
edited
Loading

Status

READY

Description

Add support for custom actions, this will allow us to implement #3, #4, #5, #71

Closes #11

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@wolfenrain wolfenrain mentioned this pull request Jan 10, 2023
Closed
7 tasks
@wolfenrain
feat: add support for custom actions
abef791
@wolfenrain
feat: add support for custom actions
8bb8901
@wolfenrain
feat: add support for custom actions
f96e33f
@wolfenrain
feat: add support for custom actions
bf57c98
@wolfenrain
feat: add support for custom actions
1483d9c
@wolfenrain
feat: add support for custom actions
4c5f431
@wolfenrain
feat: add support for custom actions
26bf3b7
@wolfenrain
feat: add support for custom actions
1979d5b
@wolfenrain
feat: add support for custom actions
54854c7
@wolfenrain
feat: add support for custom actions
436b85e
@wolfenrain
feat: add support for custom actions
8f3e286
@wolfenrain
feat: add support for custom actions
9e82a0e
@wolfenrain
feat: add support for custom actions
7a58bd5
@wolfenrain
feat: add support for custom actions
e479353
@wolfenrain
feat: add support for custom actions
f8e33c2
@wolfenrain
feat: add support for custom actions
0667660
@wolfenrain
feat: add support for custom actions
eeb9b56
@wolfenrain
feat: add support for custom actions
ec999cf
@wolfenrain
feat: add support for custom actions
59bf24e
felangel
felangel previously approved these changes Feb 16, 2023
View reviewed changes
Copy link
Collaborator

@felangel felangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a bunch of minor comments but overall LGTM ✅

Thithip
Thithip reviewed Feb 16, 2023
View reviewed changes
Copy link
Contributor

@Thithip Thithip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work, congrats! 🎉

Some comments, more questions than real remarks.

Thanks for the tools, very helpful to test it 👌

.github/workflows/main.yaml Show resolved Hide resolved
packages/fluttium_cli/test/fixtures/new/action/my_action/lib/action.dart Show resolved Hide resolved
packages/fluttium_cli/test/fixtures/new/action/my_action/lib/action.dart Show resolved Hide resolved
packages/fluttium_cli/test/fixtures/new/action/my_action/pubspec.yaml Show resolved Hide resolved
packages/fluttium/lib/src/registry.dart Show resolved Hide resolved
packages/fluttium/lib/src/actions/take_screenshot.dart Show resolved Hide resolved
packages/fluttium/lib/src/actions/input_text.dart Show resolved Hide resolved
packages/fluttium/lib/src/actions/expect_visible.dart Show resolved Hide resolved
packages/fluttium/lib/src/actions/expect_not_visible.dart Show resolved Hide resolved
packages/fluttium/test/src/registry_test.dart Show resolved Hide resolved
Thithip
Thithip previously approved these changes Feb 16, 2023
View reviewed changes
Copy link
Contributor

@Thithip Thithip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good for me! 🚀

@wolfenrain wolfenrain changed the title feat: add support for custom actions feat: add support for custom actions (#112)Co-authored-by: Felix Angelov <felangelov@gmail.com> Feb 16, 2023
@wolfenrain wolfenrain merged commit 95a557b into main Feb 16, 2023
@wolfenrain wolfenrain deleted the feat/add-support-for-custom-actions branch February 16, 2023 20:23
wolfenrain added a commit that referenced this pull request Feb 16, 2023
@wolfenrain
feat: add support for custom actions (#112)
b4adf05
@wolfenrain wolfenrain changed the title feat: add support for custom actions (#112)Co-authored-by: Felix Angelov <felangelov@gmail.com> feat: add support for custom actions (#112) Feb 16, 2023
@wolfenrain wolfenrain mentioned this pull request Feb 19, 2023
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Thithip Thithip Thithip left review comments

@felangel felangel Awaiting requested review from felangel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

spike: investigate how actions (tapOn, expectVisible, etc..) can be more extendable
3 participants
@wolfenrain @Thithip @felangel