Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: linked the rules to follow while writing GLSL code #33

Merged
merged 5 commits into from Jun 2, 2022
Merged

docs: linked the rules to follow while writing GLSL code #33

merged 5 commits into from Jun 2, 2022

Conversation

rutvik110
Copy link
Contributor

This may be helpful to let the developers know what their GLSL code should/shouldn't contain so that the generated SPIR-V properly runs on dart SPIR-V Transpiler.

PS : sorry for the earlier PR which I had to close due to some issues.

Description

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@rutvik110
Linked the rules to follow while writing GLSL
1555d85 
This may be helpful to let the developers know what their GLSL code should/shouldn't contain so that the generated SPIR-V properly runs on dart SPIR-V Transpiler.

PS : sorry for the earlier PR which I had to close due to some issues.
@rutvik110 rutvik110 changed the title Linked the rules to follow while writing GLSL docs: linked the rules to follow while writing GLSL code Jun 2, 2022
wolfenrain
wolfenrain reviewed Jun 2, 2022
View reviewed changes
Copy link
Owner

@wolfenrain wolfenrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! Left a small comment, let me know what you think ;-).

docs/shader-specifications/1-shaders.md Outdated Show resolved Hide resolved
wolfenrain
wolfenrain reviewed Jun 2, 2022
View reviewed changes
docs/shader-specifications/1-shaders.md Outdated Show resolved Hide resolved
docs/shader-specifications/1-shaders.md Outdated Show resolved Hide resolved
rutvik110 and others added 2 commits June 2, 2022 17:53
@rutvik110
removed duplicated doc content
6b864d0
@rutvik110 @wolfenrain
Update docs/shader-specifications/1-shaders.md
e8058f7 
Yah, this is much better.

Co-authored-by: Jochum van der Ploeg <jochum@vdploeg.net>
@wolfenrain
Copy link
Owner

LGTM! Thanks for the contribution!

@wolfenrain wolfenrain merged commit ee4211b into wolfenrain:main Jun 2, 2022
@rutvik110
Copy link
Contributor Author

🙌💙

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wolfenrain wolfenrain wolfenrain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rutvik110 @wolfenrain